[pbs-devel] [PATCH widget-toolkit v3 03/14] window: add panel for editing simple, built-in realms

[Christoph Heiss]

Thanks for the review!

On Fri, Aug 16, 2024 at 02:23:39PM GMT, Gabriel Goller wrote:
> On 16.08.2024 13:16, Christoph Heiss wrote:
> > diff --git a/src/window/AuthEditSimple.js b/src/window/AuthEditSimple.js
> > new file mode 100644
> > index 0000000..22932c0
> > --- /dev/null
> > +++ b/src/window/AuthEditSimple.js
> > @@ -0,0 +1,41 @@
> > +Ext.define('Proxmox.panel.SimpleRealmInputPanel', {
> > +    extend: 'Proxmox.panel.InputPanel',
> > +    xtype: 'pmxAuthSimplePanel',
> > +    mixins: ['Proxmox.Mixin.CBind'],
> > +
> > +    type: 'simple',
> > +
> > +    column1: [
> > +	{
> > +	    xtype: 'pmxDisplayEditField',
> > +	    name: 'realm',
> > +	    cbind: {
> > +		value: '{realm}',
> > +	    },
> > +	    fieldLabel: gettext('Realm'),
> > +	    allowBlank: false,
>
> Hmm I think `allowBlank` is useless here, as it's not editable.

Good catch! I've took the LDAP panel as base, where this field *can* be
editable. I'll remove it with the next revision.

>
> > [..]
> > +    columnB: [
> > +	{
> > +	    xtype: 'proxmoxtextfield',
> > +	    name: 'comment',
> > +	    fieldLabel: gettext('Comment'),
>
> But here `allowBlank: false` would be useful!

Sure, makes sense in that case!