[pbs-devel] [PATCH proxmox-backup/pwt v2 00/14] fix #5379: introduce default auth realm option
Christoph Heiss
c.heiss at proxmox.com
Mon Aug 12 15:54:57 CEST 2024
Fixes #5379 [0].
First, it adds an updatable `default` field to all existing editable
realms. Then it converts the PAM and PBS built-in realms to proper
realms, instead of being hard-coded in-between somewhere.
In turns this enables editing of these realms, allowing setting whether
these realms should be the default for login or not.
For proxmox-widget-toolkit, the first three patches could in principal
be applied on their own. The others depend on the API changes as
introduced in the proxmox-backup part.
W.r.t. the inconsistency as discovered/discussed in [1], the (current)
behaviour is not changed in this series. Since both PVE and PBS use the
same realm login dialog from proxmox-widget-toolkit, I'd rather fix it
separately -- to avoid blocking this series on a completely separate
issue, which might still need some discussing.
W.r.t. to applying, proxmox-backup will need a bump of
proxmox-widget-toolkit afterwards.
[0] https://bugzilla.proxmox.com/show_bug.cgi?id=5379
[1] https://lists.proxmox.com/pipermail/pbs-devel/2024-August/010429.html
History
=======
v1: https://lists.proxmox.com/pipermail/pbs-devel/2024-July/010250.html
Changes v1 -> v2:
* rebased on latest master
* trivial fixes as suggested by Lukas
* add documentation to unset_default_realm()
Diffstat
========
proxmox-widget-toolkit:
Christoph Heiss (6):
window: AuthEditBase: include more information in thrown errors
panel: AuthView: make `useTypeInUrl` property per-realm
window: add panel for editing simple, built-in realms
schema: make PAM realm editable using new AuthSimple panel
fix #5379: panel: AuthView: add column displaying whether the realm is
default
fix #5379: window: AuthEdit{LDAP,OpenId}: add 'Default realm' checkbox
src/Makefile | 1 +
src/Schema.js | 7 +++++-
src/panel/AuthView.js | 13 +++++++++---
src/window/AuthEditBase.js | 8 +++----
src/window/AuthEditLDAP.js | 14 +++++++++++-
src/window/AuthEditOpenId.js | 13 ++++++++++++
src/window/AuthEditSimple.js | 41 ++++++++++++++++++++++++++++++++++++
7 files changed, 88 insertions(+), 9 deletions(-)
create mode 100644 src/window/AuthEditSimple.js
proxmox-backup:
Christoph Heiss (8):
fix #5379: api-types: add `default` field to all realm types
fix #5379: api2: access: set default realm accordingly on individual
update
api-types: introduce proper types for PAM and PBS realms
config: use new dedicated PAM and PBS realm types
api2: access: add update support for built-in PAM realm
api2: access: add update support for built-in PBS realm
www: AccessControl: make `useTypeInUrl` property per-realm
www: utils: make built-in pbs realm editable using new AuthSimplePanel
pbs-api-types/src/ad.rs | 7 ++
pbs-api-types/src/ldap.rs | 7 ++
pbs-api-types/src/lib.rs | 97 ++++++++++++++++++++++-
pbs-api-types/src/openid.rs | 7 ++
pbs-config/src/domains.rs | 31 +++++++-
src/api2/access/domain.rs | 13 ----
src/api2/config/access/ad.rs | 7 ++
src/api2/config/access/ldap.rs | 7 ++
src/api2/config/access/mod.rs | 4 +
src/api2/config/access/openid.rs | 7 ++
src/api2/config/access/pam.rs | 130 +++++++++++++++++++++++++++++++
src/api2/config/access/pbs.rs | 130 +++++++++++++++++++++++++++++++
src/bin/proxmox-backup-api.rs | 1 +
src/config/mod.rs | 25 ++++++
www/Utils.js | 4 +-
www/panel/AccessControl.js | 1 -
16 files changed, 460 insertions(+), 18 deletions(-)
create mode 100644 src/api2/config/access/pam.rs
create mode 100644 src/api2/config/access/pbs.rs
--
2.45.1
More information about the pbs-devel
mailing list