[pbs-devel] [PATCH backup 4/5] fix typos in strings

[Thomas Lamprecht]

On 07/08/2024 12:52, Lukas Wagner wrote:
> On  2024-08-07 12:32, Maximiliano Sandoval wrote:
>> Signed-off-by: Maximiliano Sandoval <m.sandoval at proxmox.com>
>> ---
>>  docs/lto-barcode/page-calibration.js | 8 ++++----
>>  pbs-api-types/src/ldap.rs            | 2 +-
>>  src/api2/node/tasks.rs               | 2 +-
>>  3 files changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/docs/lto-barcode/page-calibration.js b/docs/lto-barcode/page-calibration.js
>> index 3c7fed82..54512a9f 100644
>> --- a/docs/lto-barcode/page-calibration.js
>> +++ b/docs/lto-barcode/page-calibration.js
>> @@ -108,7 +108,7 @@ Ext.define('PageCalibration', {
>>  		    xtype: 'numberfield',
>>  		    value: 'a4',
>>  		    name: 's_x',
>> -		    fieldLabel: 'Meassured Start Offset Sx (mm)',
>> +		    fieldLabel: 'Measured Start Offset Sx (mm)',
> 
> I wonder, shouldn't these use gettext?
> 

The LTO barcode label tool [0] has no gettext infra and is currently also not
considered when extracting texts for the i18n repo. In that small app the
gettext function is defined as identity function [1] just to avoid that the
widget-toolkit breaks.

While we could naturally add i18n support, the LTO barcode label app is a
1) rather niche tool and 2) not really complex, so it might be a bit overkill,
at least without users requesting i18n support there.


[0]: https://pbs.proxmox.com/docs/lto-barcode/index.html
[1]: https://git.proxmox.com/?p=proxmox-backup.git;a=blob;f=docs/lto-barcode/lto-barcode.js;h=2aeaba1b6084c5baf178a8cf5445e6c728dae719;hb=ab8e84498d9cba8be280ebbeb2ffe9daf6cc439a#l1