[pbs-devel] [PATCH proxmox 01/10] clippy: remove needless borrow

Maximiliano Sandoval m.sandoval at proxmox.com
Wed Aug 7 09:43:47 CEST 2024


Fixes the clippy warning:

warning: this expression borrows a value the compiler would automatically borrow
   --> proxmox-apt/src/repositories/file/sources_parser.rs:111:40
    |
111 | ...                   types.push((&package_type[..]).parse()?);
    |                                  ^^^^^^^^^^^^^^^^^^^ help: change this to: `package_type[..]`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
    = note: `#[warn(clippy::needless_borrow)]` on by default

Signed-off-by: Maximiliano Sandoval <m.sandoval at proxmox.com>
---
 proxmox-apt/src/repositories/file/sources_parser.rs | 2 +-
 proxmox-router/src/cli/completion.rs                | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/proxmox-apt/src/repositories/file/sources_parser.rs b/proxmox-apt/src/repositories/file/sources_parser.rs
index 017162bb..2510d107 100644
--- a/proxmox-apt/src/repositories/file/sources_parser.rs
+++ b/proxmox-apt/src/repositories/file/sources_parser.rs
@@ -108,7 +108,7 @@ impl<R: BufRead> APTSourcesFileParser<R> {
                         }
                         let mut types = Vec::<APTRepositoryPackageType>::new();
                         for package_type in values {
-                            types.push((&package_type[..]).parse()?);
+                            types.push((package_type[..]).parse()?);
                         }
                         repo.types = types;
                     }
diff --git a/proxmox-router/src/cli/completion.rs b/proxmox-router/src/cli/completion.rs
index 47444243..5a899eec 100644
--- a/proxmox-router/src/cli/completion.rs
+++ b/proxmox-router/src/cli/completion.rs
@@ -151,7 +151,7 @@ fn get_simple_completion_do(
                     return get_property_completion(
                         schema,
                         prop_name,
-                        &completion_functions,
+                        completion_functions,
                         &args[0],
                         done,
                     );
@@ -198,7 +198,7 @@ fn get_simple_completion_do(
                 return get_property_completion(
                     schema,
                     prop_name,
-                    &completion_functions,
+                    completion_functions,
                     prefix,
                     done,
                 );
-- 
2.39.2





More information about the pbs-devel mailing list