[pbs-devel] [PATCH proxmox-backup] fix #2996: client: allow optional match pattens for restore

Christian Ebner c.ebner at proxmox.com
Tue Apr 30 17:35:16 CEST 2024


> On 30.04.2024 17:19 CEST Gabriel Goller <g.goller at proxmox.com> wrote:
> 
>  
> Gave this a quick spin and it worked quite good!
> 
> The only thing that didn't work was when I used '-' as a target, which
> should print everything to stdout. When using it, the --matches
> parameter is simply ignored and it dumps the whole archive on stdout.
> E.g.:
> 
>     proxmox-backup-client restore --matches README.rst host/debian/2024-04-30T15:08:06Z test.pxar.didx -
> 
> Not sure if this is in the scope of this patch or not though.
> 
> If it isn't, you can consider: 
> 
> Tested-by: Gabriel Goller <g.goller at proxmox.com>

Thanks a lot for testing and good catch! This should indeed not be possible and I need to add a check to disallow this combination of the `matches` being set and the `target` being stdout. Will send a new version.

Cheers,
Chris




More information about the pbs-devel mailing list