[pbs-devel] applied: [PATCH proxmox v3 1/2] metrics: encode influxdb org and bucket parameters

[Thomas Lamprecht]

Am 26/04/2024 um 16:02 schrieb Gabriel Goller:
> In order to remove the current limitations on the bucket and
> organization names, we need to make sure that they are transmitted
> correctly. In order to do this, we encode them using the url crate.
> 
> This way we support organization/bucket names that include slashes,
> whitespaces, etc.
> 
> Signed-off-by: Gabriel Goller <g.goller at proxmox.com>
> ---
>  proxmox-metrics/Cargo.toml           | 1 +
>  proxmox-metrics/src/influxdb/http.rs | 7 ++++++-
>  2 files changed, 7 insertions(+), 1 deletion(-)
> 
>

applied, thanks!

Having some tests here might be nice though. E.g., moving the URI assembly
into a separate method and having either a test module or doc-tests to
ensure that some common and odd cases, e.g. those requiring encoding, are
handled correctly.