[pbs-devel] [PATCH many v4 00/43] integrate notification system

Maximiliano Sandoval m.sandoval at proxmox.com
Mon Apr 22 15:58:17 CEST 2024


Lukas Wagner <l.wagner at proxmox.com> writes:

> These patches integrate the notification system which was introduced in Proxmox VE
> in 8.1 into Proxmox Backup Server.

I tested v3 of this patch series.

Tested that the following things work as expected:
 - Error notification sent for ACME accounts
 - GC notification
 - verification notification
 - Legacy vs Notification system
 - Adding a matcher for successful prunes and receiving a prune notification

I already discussed this with Lukas off-list: When a notification is
queued and it does not match any matcher it should be logged, e.g. with
a message

```
proxmox-backup-proxy[PID]: discarding notification (id=NOTIFICATION_ID).
it does not match any matcher
```

otherwise the journal will only show:

```
Apr 22 11:19:50 pbs proxmox-backup-proxy[21341]: queued notification (id=5ae8da0a-afa7-4635-9d67-1645e6c47310)
```

and no reason of why such notification was never sent.


Tested-by: Maximiliano Sandoval <m.sandoval at proxmox.com>

-- 
Maximiliano




More information about the pbs-devel mailing list