[pbs-devel] [PATCH proxmox-backup 0/4] more follow-ups

[Fabian Grünbichler]

the series in general is definitely a step in the right direction - but
I really dislike the amount of duplication. IMHO we can collapse the new
job status into the status (or rather, flatten the latter into the
former). the only downside is that we can't flatten a non-existing
status except as default values (all zeroes), but that was already the
case with the old endpoint as well (which returned all zeroes despite no
GC ever having run). the UI (as well as any third party client) can
easily handle this, and it only affects stores where GC has never run,
so IMHO that's an okay tradeoff.

what do you think?

besides that, some of the R-b trailers have a typo, I would correct
those as well and push the combination of all three (original series,
Dominik's and my followup patches) unless there are objections.

Fabian Grünbichler (4):
  GC: flatten existing status into job status
  api: merge garbage-collection-status and -job-status
  ui: don't re-calculate GC duration
  GC status: reduce code duplication

 pbs-api-types/src/datastore.rs |  26 ++----
 src/api2/admin/datastore.rs    | 153 +++++++++------------------------
 src/api2/admin/gc.rs           |   8 +-
 www/Utils.js                   |   8 +-
 www/config/GCView.js           |  21 ++---
 5 files changed, 62 insertions(+), 154 deletions(-)

-- 
2.39.2