[pbs-devel] [PATCH proxmox-backup v8 02/23] pbs-api-types: add backing-device to DataStoreConfig

Dietmar Maurer dietmar at proxmox.com
Mon Apr 22 11:48:20 CEST 2024


> On 22.4.2024 11:29 CEST Dietmar Maurer <dietmar at proxmox.com> wrote:
> 
>  
> > > +pub const REMOVABLE_DATASTORE_MOUNT_DIR: &str = "/mnt/removable_datastore";
> > 
> > please use kebab-case: removable-datastore 
> > 
> > It would be great to write some reasoning for using a different mount
> > path for removable datastore, as IMO that's really not something
> > obvious..
> > 
> > In fact, why do we require having that separate?
> 
> I can imagine problems if the user tries to add the same removable datastore multiple times with different names, or if something fails during add datastore.
> 
> not sure about this...


Another problem arise if we allow multiple datastores on a single disk.

Using a fixed REMOVABLE_DATASTORE_MOUNT_DIR solves those problems.




More information about the pbs-devel mailing list