[pbs-devel] [PATCH proxmox-backup v2 3/3] pbs-api-types: add check for allowed maintenmance mode changes

Thomas Lamprecht t.lamprecht at proxmox.com
Mon Apr 22 09:20:20 CEST 2024


This is a semantic change where the fact that code is touched that's inside a
crate named pbs-api-types is rather an implementation detail, I'd rather use
something like the following as subject:

api: assert that maintenance mode transitions are valid


And having some commit message with some basic reasoning would be also great..

If this was ordered as second patch, i.e., without the new maintenance mode,
we could already apply that and Hannes could add the patch that adds the
maintenance mode to his series, which would be nicer to review and apply
(and IMO a slightly better commit order)




More information about the pbs-devel mailing list