[pbs-devel] [PATCH widget-toolkit/proxmox-backup v3 0/9] Fix #3115: VLAN Network Interface Configuration

[Folke Gleumes]

As I just discovered that this bug is also present in PVE and its just
a small visual inconsistency, I don't think its a blocker.

On Thu, 2024-04-18 at 11:43 +0200, Folke Gleumes wrote:
> Found a small ui bug in the vlan dialog: When the advanced checkbox
> is
> not active, the first few pixel rows of the upper left input box are
> cut off.
> 
> When the ui is fixed, you can consider this:
> 
> Tested-by: Folke Gleumes <f.gleumes at proxmox.com>
> 
> On Thu, 2024-04-04 at 12:00 +0200, Stefan Lendl wrote:
> > This patch series allows configuring a VLAN network interfaces in
> > the
> > PBS GUI
> > 
> > * Added reading and writing of VLAN network config.
> > * Created and updating of VLAN network interfaces via the API.
> > * Copied the VLAN field widget from PVE and enabled the Linux VLAN
> > interface
> >   type in the GUI.
> > * Unit tests for reading and writing the network config.
> > * Some cleanup to leave touched functions cleaner than before.
> > 
> > Changes v2 -> v3:
> > * slightly updated commit messages and changed typo in git trailer
> > 
> > Changes v1 -> v2:
> > * Adapted parameter handling to not expect all properties to be set
> > * Incorporated style suggestions
> > 
> > widget-toolkit:
> > 
> > Stefan Lendl (1):
> >   form: include vlan field widget from PVE
> > 
> >  src/Makefile            |  1 +
> >  src/form/VlanField.js   | 40
> > ++++++++++++++++++++++++++++++++++++++++
> >  src/node/NetworkEdit.js |  6 +++---
> >  3 files changed, 44 insertions(+), 3 deletions(-)
> >  create mode 100644 src/form/VlanField.js
> > 
> > 
> > proxmox-backup:
> > 
> > Stefan Lendl (8):
> >   tests: move network tests to parser.rs
> >   tests: simple tests for writing the network config
> >   config: write vlan network interface
> >   config: parse vlan interface from config
> >   config: remove unnecessary pub in various methods in
> > NetworkConfig
> >   fmt: fix intendation in api macro
> >   api: create and update vlan interfaces
> >   ui: enable vlan widget
> > 
> >  pbs-api-types/src/network.rs     |  17 ++
> >  pbs-config/src/network/lexer.rs  |   6 +
> >  pbs-config/src/network/mod.rs    | 300 +++++++++++++++++----------
> > --
> > --
> >  pbs-config/src/network/parser.rs | 249 ++++++++++++++++++++++++-
> >  src/api2/node/network.rs         |  72 +++++++-
> >  www/SystemConfiguration.js       |   2 +-
> >  6 files changed, 504 insertions(+), 142 deletions(-)
> > 
> > 
> > Summary over all repositories:
> >   9 files changed, 548 insertions(+), 0 deletions(-)
> > 
> 
> 
> 
> _______________________________________________
> pbs-devel mailing list
> pbs-devel at lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel