[pbs-devel] [PATCH proxmox-backup v4 09/22] pbs-api-types: datastore: use new proxmox_schema::de for deserialization

Christian Ebner c.ebner at proxmox.com
Wed Apr 17 11:38:04 CEST 2024


On 4/17/24 11:08, Hannes Laimer wrote:
> On Wed Apr 17, 2024 at 10:13 AM CEST, Christian Ebner wrote:
>> Still not to happy about the commit title, but no hurt feelings
> 
> actually we don't even need this anymore for this series, but yes,
> missed it, no reason for not changing the message

but it does not hurt either, and is more readable than the previous 
deserialization.

Now that I had another look at this, you might bring the 
`SchemaDeserializer` in scope with a `use` statement at the top so you 
don't need it below, that might help to make this even more readable.




More information about the pbs-devel mailing list