[pbs-devel] [PATCH proxmox-backup v4 00/22] add removable datastores

[Christian Ebner]

Had a look at the new version of the patches and must say nice work.

My comments are mostly me being picky and do not block this being applied.

So please consider this:
Tested-by: Christian Ebner <c.ebner at proxmox.com>

and for the Rust part also:
Reviewed-by: Christian Ebner <c.ebner at proxmox.com>

Some ideas for possible future improvements:

What I am still missing is a way to partition and format the disk for it 
being usable as reusable datastore directly via the UI. So a workflow 
like, attaching new disk, wipe its contents, create partition and 
filesystem and create removable datastore on it, where the latter to 
might be combined.

An other feature which might be interesting, are automated job 
executions once the datastore is online after being mounted,
e.g. start a verification job or perform a garbage collection.