[pbs-devel] [PATCH proxmox-backup 00/33] integrate notification system

[Gabriel Goller]

First of all, thanks for implementing this! I can't count how many times
I've seen a forum post asking for better notifications in pbs!

Some high-level comments:
 - The 'hostname' field doesn't make any sense in pbs (AFAICT) because
   there is only one node.
 - The 'type' field could have hardcoded values, such as 'gc', 'verify',
   etc. this way we can also have a drop-down menu in the ui. This makes
   it a lot easier than checking the docs/guessing.
 - A notification when a backup succeeds/fails would be very useful as
   well.
 - Also having datastore and namespace filters on the notification
   matchers would be great (if feasible obv.).


Another thing I noticed is that creating a datastore through the cli 
still uses the legacy notification system.

Will make a more in depth review next week!