[pbs-devel] [PATCH proxmox v3 1/5] compression: deflate: Move encoder into a mod

Gabriel Goller g.goller at proxmox.com
Fri Apr 12 14:41:30 CEST 2024


On Wed Apr 10, 2024 at 4:30 PM CEST, Maximiliano Sandoval wrote:
> diff --git a/proxmox-compression/src/lib.rs b/proxmox-compression/src/lib.rs
> index 1fcfb977..239de623 100644
> --- a/proxmox-compression/src/lib.rs
> +++ b/proxmox-compression/src/lib.rs
> @@ -1,6 +1,6 @@
> -mod compression;
> -pub use compression::*;
> +pub use deflate::{DeflateEncoder, Level};
>  
> +pub(crate) mod deflate;

Whole series looks good, so consider:

Reviewed-by: Gabriel Goller <g.goller at proxmox.com>

The only nit is the above 'pub(crate)', which can be removed!




More information about the pbs-devel mailing list