[pbs-devel] applied: [PATCH proxmox-backup v3] api: make prune-group a real workertask

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Apr 9 12:44:24 CEST 2024


Am 08/03/2024 um 14:36 schrieb Gabriel Goller:
> `prune-group` is currently not a real workertask, ie it behaves like one
> but doesn't start a thread nor a task to do its work.
> 
> Changed it to start a tokio-task, so that we can delete snapshots
> asynchronously. The `dry-run` feature still behaves in the same way and
> returns early.
> 
> This paves the way for the new logging infra (which uses `task_local` to
> define a logger) and improves performance of bigger backup-groups.
> 
> Signed-off-by: Gabriel Goller <g.goller at proxmox.com>
> ---
> 
> v3, thanks @Max
>  * remove use-task parameter, extract from serde Value
>  * simplify dry-run statement
>  * removed prune-result output
>  * inline variables in formatting call
> 
> v2, thanks @Fiona, @Thomas:
>  * use feature flag to activate, so we don't break the api 
>  * convert the result to a structure and print it in the tasklog
>  * enable the feature flag in the frontend
> 
> 
>  src/api2/admin/datastore.rs | 152 ++++++++++++++++++++++--------------
>  www/datastore/Prune.js      |   1 +
>  2 files changed, 96 insertions(+), 57 deletions(-)
> 
>

applied, thanks!




More information about the pbs-devel mailing list