[pbs-devel] applied: [PATCH proxmox-backup v3] api: enhance directory existence check

[Thomas Lamprecht]

The commit subject is not really telling, "enhance" can mean lots of things
and which directory check is meant would be also good to get here...

I changed it to:

"api: datastore create: allow re-using existing dirs if empty & not a mountpoint"

It's a bit crowded, but much more telling about what this is about.

I also reworded the commit message, as when reading first I got slightly
confused and for a moment thought that we allowed this before your patch, but
would not allow it anymore now.


Am 30/11/2023 um 11:37 schrieb Markus Frank:
> If a directory exists on the specified path,
> it now also checks whether the directory is empty and not already mounted.
> 
> Previously, if a directory were deleted and a directory with the same name
> would be created, the old check prevented the creation even though the
> directory could be used as a mount point.
> 
> Signed-off-by: Markus Frank <m.frank at proxmox.com>
> Tested-by: Christian Ebner <c.ebner at proxmox.com>
> ---
> v3: changed comment
> v2: added check if another file system is mounted on the specified path
> 
>  src/api2/node/disks/directory.rs | 15 ++++++++++++---
>  1 file changed, 12 insertions(+), 3 deletions(-)
> 
>

applied, thanks!