[pbs-devel] [PATCH v3 proxmox-backup 51/58] pxar: create: show chunk injection stats debug output

[Fabian Grünbichler]

Quoting Christian Ebner (2024-03-28 13:37:00)
> Signed-off-by: Christian Ebner <c.ebner at proxmox.com>
> ---
> changes since version 2:
> - not present in previous version
> 
>  pbs-client/src/pxar/create.rs | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/pbs-client/src/pxar/create.rs b/pbs-client/src/pxar/create.rs
> index f103127c4..461509c39 100644
> --- a/pbs-client/src/pxar/create.rs
> +++ b/pbs-client/src/pxar/create.rs
> @@ -407,6 +407,14 @@ where
>      encoder.finish().await?;
>      encoder.close().await?;
>  
> +    log::info!(
> +        "Total injected: {} ({} chunks), total reused payload: {}, padding: {} ({} partial chunks)",

we already discussed this off-list, but something like

Change detection: processed XX files, YY unmodified (reused AA GB data + BB GB padding = CC GB total in DD chunks)

and only printing it with change detection metadata is probably easier to
understand, but maybe we should get some more feedback on that as well :)

> +        HumanByte::from(archiver.total_injected_size),
> +        archiver.total_injected_count,
> +        HumanByte::from(archiver.total_reused_payload_size),
> +        HumanByte::from(archiver.total_injected_size - archiver.total_reused_payload_size),
> +        archiver.partial_chunks_count,
> +    );
>      Ok(())
>  }
>  
> -- 
> 2.39.2
> 
> 
> 
> _______________________________________________
> pbs-devel mailing list
> pbs-devel at lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
> 
>