[pbs-devel] [PATCH v3 proxmox-backup 31/58] www: cover meta extension for pxar archives

[Christian Ebner]

On 4/4/24 12:01, Fabian Grünbichler wrote:
> On March 28, 2024 1:36 pm, Christian Ebner wrote:
>> Allows to access the pxar meta archives for navigation and download
>> via the Proxmox Backup Server web ui.
>>
>> Signed-off-by: Christian Ebner <c.ebner at proxmox.com>
>> ---
>> changes since version 2:
>> - use mpxar and ppxar file extensions
>>
>>   www/datastore/Content.js | 6 ++++--
>>   1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/www/datastore/Content.js b/www/datastore/Content.js
>> index c2403ff9c..eb25f6ca4 100644
>> --- a/www/datastore/Content.js
>> +++ b/www/datastore/Content.js
>> @@ -1050,7 +1050,7 @@ Ext.define('PBS.DataStoreContent', {
>>   		    tooltip: gettext('Browse'),
>>   		    getClass: (v, m, { data }) => {
>>   			if (
>> -			    (data.ty === 'file' && data.filename.endsWith('pxar.didx')) ||
>> +			    (data.ty === 'file' && (data.filename.endsWith('pxar.didx') || data.filename.endsWith('mpxar.didx'))) ||
>>   			    (data.ty === 'ns' && !data.root)
>>   			) {
>>   			    return 'fa fa-folder-open-o';
>> @@ -1058,7 +1058,9 @@ Ext.define('PBS.DataStoreContent', {
>>   			return 'pmx-hidden';
>>   		    },
>>   		    isActionDisabled: (v, r, c, i, { data }) =>
>> -			!(data.ty === 'file' && data.filename.endsWith('pxar.didx') && data['crypt-mode'] < 3) && data.ty !== 'ns',
>> +			!(data.ty === 'file' &&
>> +			(data.filename.endsWith('pxar.didx') || data.filename.endsWith('mpxar.didx')) &&
>> +			data['crypt-mode'] < 3) && data.ty !== 'ns',
> 
> is this patch needed? the filename now always ends with pxar.didx (note
> the missing leading '.') ;)
> 
> if we want to keep it and only make non-split archives and the meta
> archives browsable, then we need to add the '.'

True, I will add the dot so only pxar and mpxar files can be browsed, as 
otherwise it might be confusing (although we allow the ppxar to be used 
for the cli commands).