[pbs-devel] [PATCH proxmox-backup 1/2] ui: tape: restore: improve variable names
Dominik Csapak
d.csapak at proxmox.com
Fri Sep 29 15:39:23 CEST 2023
some of the variable names did not really tell the full story, so extend
them a bit. This makes the intention much clearer.
Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
---
www/tape/window/TapeRestore.js | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/www/tape/window/TapeRestore.js b/www/tape/window/TapeRestore.js
index c1d3493c..3008f359 100644
--- a/www/tape/window/TapeRestore.js
+++ b/www/tape/window/TapeRestore.js
@@ -721,7 +721,7 @@ Ext.define('PBS.TapeManagement.SnapshotGrid', {
let me = this;
let snapshots = [];
- let storeCounts = {};
+ let selectedStoreCounts = {};
me.getSelection().forEach((rec) => {
let id = rec.get('id');
@@ -730,10 +730,10 @@ Ext.define('PBS.TapeManagement.SnapshotGrid', {
// only add if not filtered
if (me.store.findExact('id', id) !== -1) {
snapshots.push(`${store}:${snap}`);
- if (storeCounts[store] === undefined) {
- storeCounts[store] = 0;
+ if (selectedStoreCounts[store] === undefined) {
+ selectedStoreCounts[store] = 0;
}
- storeCounts[store]++;
+ selectedStoreCounts[store]++;
}
});
@@ -745,17 +745,17 @@ Ext.define('PBS.TapeManagement.SnapshotGrid', {
}
let wholeStores = [];
- let wholeStoresSelected = true;
- for (const [store, count] of Object.entries(storeCounts)) {
- if (me.storeCounts[store] === count) {
+ let onlyWholeStoresSelected = true;
+ for (const [store, selectedCount] of Object.entries(selectedStoreCounts)) {
+ if (me.storeCounts[store] === selectedCount) {
wholeStores.push(store);
} else {
- wholeStoresSelected = false;
+ onlyWholeStoresSelected = false;
break;
}
}
- if (wholeStoresSelected) {
+ if (onlyWholeStoresSelected) {
return wholeStores;
}
--
2.30.2
More information about the pbs-devel
mailing list