[pbs-devel] [PATCH widget-toolkit] fix #4961: disks: increase timeout to 1min

[Dominik Csapak]

On 9/26/23 09:55, Fabian Grünbichler wrote:
> On September 21, 2023 10:21 am, Gabriel Goller wrote:
>> Increase the timeout of the api call to `../nodes/localhost/disks/list`
>> to 1min. When having a lot of disks the default timeout of 30sec is
>> not enough.
>>
>> Signed-off-by: Gabriel Goller <g.goller at proxmox.com>
>> ---
>>   src/panel/DiskList.js | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/src/panel/DiskList.js b/src/panel/DiskList.js
>> index c5a0050..5785297 100644
>> --- a/src/panel/DiskList.js
>> +++ b/src/panel/DiskList.js
>> @@ -70,6 +70,7 @@ Ext.define('Proxmox.DiskList', {
>>   		type: 'proxmox',
>>   		extraParams: extraParams,
>>   		url: url,
>> +		timeout: 60*1000,
> 
> that alone won't be enough, since we also have a 30s timeout for
> proxying requests in a PVE cluster (and this component is used there).

it would actually be enough to fix that exact bug, which is for pbs
where we don't have the 30s proxy limit, but you're right it's not
a generic fix across both products

imho we could still apply this here (maybe with a short test to
see if it doesn't make the situation worse for pve) so it's fixed
for pbs at least and can properly fix it for pve later still