[pbs-devel] [PATCH proxmox-backup v2 00/25] add removable datastores

Hannes Laimer h.laimer at proxmox.com
Thu Sep 21 14:51:42 CEST 2023

These patches add support for removable datastores. All removable
datastores have a backing-device(a UUID) associated with them. Removable
datastores work like normal ones, just that they can be unplugged. It is
possible to create a removable datastore, sync backups onto it, unplug
it and use it on a different PBS.

The datastore path is also the mountpoint for the removable datastore.
By default when creating one through the web UI it will be
`/mnt/removable-datastores/<UUID>`, using the CLI it is possible to
specify something else. Since a removable datastore is associated with
the UUID of a partition, it is technically possible to have two
removable datastores on the same device, but I don't think there is a
use-case that couldn't also be done using namespaces.

When a removable datastore is deleted and 'destroy-data' is set, the
device has to be plugged in. If 'destroy-data' is not set the datastore
can be deleted even if the device is not present. Removable datastores
are automatically mounted when plugged in. At the API service start all
removable datastores are marked as 'unplugged', unless they are already

Patches 16/25 and 18/25 are not strictly needed, but they made sense in
this context, so I kept them in this series.

thanks @Lukas and @Thomas for the feedback
 * fix datastore 'add' button in the UI
 * some format!("{}", a) -> format!("{a}")
 * replace `const` with `let` in js code
 * change icon `fa-usb` -> `fa-plug`
 * add some docs
 * add JDoc for parseMaintenanceMode
 * proxmox-schema dep bump 

Hannes Laimer (25):
  tools: add disks utility functions
  pbs-api-types: add backing-device to DataStoreConfig
  maintenance: add 'Unpplugged' maintenance type
  disks: add UUID to partition info
  api2: admin: add (un)mount endpoint for removable datastores
  add helper for checking if a removable datastore is available
  api2: removable datastore creation
  ui: add partition selector form
  api2: disks list: add only-unused flag
  ui: add removable datastore creation support
  ui: add (un)mount button to summary
  pbs-api-types: datastore: use new proxmox_scheme::de for
  pbs-api-types: add removable/is-available flag to DataStoreListItem
  ui: display removable datastores in list
  ui: utils: render unplugged maintenance mode correctly
  ui: utils: make parseMaintenanceMode more robust
  ui: add datastore status mask for unplugged removable datastores
  ui: maintenance: fix disable msg field if no type is selected
  ui: maintenance: disable edit if unplugged
  pb-manager: add (un)mount command
  add auto-mounting for removable datastores
  api: mark removable datastores as unplugged after restart
  datastore: handle deletion of removable datastore properly
  docs: mention maintenance mode reset when removable datastore is
  bump proxmox-schema dependency to 2.0.1

 Cargo.toml                                  |   2 +-
 debian/control                              |   4 +-
 debian/proxmox-backup-server.install        |   1 +
 debian/proxmox-backup-server.udev           |   3 +
 docs/maintenance.rst                        |   2 +
 etc/Makefile                                |   3 +-
 etc/removable-device-attach at .service.in     |   8 +
 pbs-api-types/src/datastore.rs              |  40 ++++-
 pbs-api-types/src/maintenance.rs            |  35 +++-
 pbs-datastore/src/datastore.rs              |  28 +++-
 pbs-datastore/src/lib.rs                    |   2 +-
 src/api2/admin/datastore.rs                 | 175 +++++++++++++++++++-
 src/api2/config/datastore.rs                |  67 +++++++-
 src/api2/node/disks/mod.rs                  |   8 +
 src/api2/status.rs                          |  18 +-
 src/bin/proxmox-backup-api.rs               |  18 ++
 src/bin/proxmox_backup_manager/datastore.rs |  60 ++++++-
 src/tools/disks/mod.rs                      |  96 +++++++++--
 www/Makefile                                |   1 +
 www/NavigationTree.js                       |  10 +-
 www/Utils.js                                |  31 +++-
 www/css/ext6-pbs.css                        |  20 +++
 www/datastore/DataStoreListSummary.js       |   1 +
 www/datastore/Summary.js                    | 108 ++++++++++--
 www/form/PartitionSelector.js               |  59 +++++++
 www/window/DataStoreEdit.js                 |  50 ++++++
 www/window/MaintenanceOptions.js            |  16 +-
 27 files changed, 803 insertions(+), 63 deletions(-)
 create mode 100644 etc/removable-device-attach at .service.in
 create mode 100644 www/form/PartitionSelector.js


More information about the pbs-devel mailing list