[pbs-devel] [PATCH proxmox-backup 05/23] api2: admin: add (un)mount endpoint for removable datastores

[Lukas Wagner]

On 9/21/23 09:50, Hannes Laimer wrote:
> On 9/19/23 15:38, Lukas Wagner wrote:
>>
>>
>> On 9/15/23 08:54, Hannes Laimer wrote:
>>> +pub fn do_mount_device(
>>> +        datastore.set_maintenance_mode(None);
>>
>> I think this overrides existing maintenance modes... e.g. if a datastore
>> is 'read-only', unmounted and mounted again, then the 'read-only' mode 
>> will be gone.
>>
> Yes, it does. Why should it not? The only situation where that could be
> a problem is if a removable datastore should not be written to at all,
> so it would either be unplugged or ro. But in this case, why setup sync
> jos or backups to a datastore that should not be written to in the first
> place?
> 

I agree that there might be limited number of use cases where this is 
actually a problem. That being said, from a user's perspective I would 
find this behavior quite surprising if I were to stumble across it. I 
guess that's due to the fact that it is not really apparent that 'not 
mounted' is also handled as a maintenance mode, that replaces others.

If you keep this behavior as is, it should at least be documented in the 
admin guide.

-- 
- Lukas