[pbs-devel] applied: [PATCH proxmox-backup v3] fix #4343: updated `view_task_result` to bail on task failure

Thomas Lamprecht t.lamprecht at proxmox.com
Mon Sep 18 16:40:18 CEST 2023


Am 08/09/2023 um 15:32 schrieb Gabriel Goller:
> Now we make an additional request on `api2/json/.../tasks/{upid}/status` to
> get the `exitstatus` of the task. This allows us to `bail` and thus
> get a non-zero exit code in the cli.
> 
> Signed-off-by: Gabriel Goller <g.goller at proxmox.com>
> ---
> 
> changes v2:
>  - removed unrelated cleanup
> 
> changes v1:
>  - check on each iteration if the task is finished, then bubble up the 
>    original error of the task. This was inpractical though, so we print
>    the error and return a generic error.
> 
>  pbs-client/src/task_log.rs | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
>

applied, thanks!





More information about the pbs-devel mailing list