[pbs-devel] [PATCH proxmox-backup] close #3777: api: Add source information to backup logs

Gabriel Goller g.goller at proxmox.com
Wed Sep 13 10:12:39 CEST 2023


On 9/13/23 09:08, Thomas Lamprecht wrote:
> Am 08/09/2023 um 16:01 schrieb Gabriel Goller:
>> On 9/7/23 18:53, Thomas Lamprecht wrote:
>>> Oh, and for quite a few users the IPv4 mapped as IPv6 notation looks odd, so dropping the
>>> ::ffff: prefix might be worth it, but no hard feelings, we can always change that if there
>>> are complaints..
>> Noticed that too, but IMO staying 'correct' is more important than making the output pretty.
> How is a IPv4 mapped as IPv6 more correct than a IPv4, it's literally the same thing
> in two different notations?
You're right, they are the same thing, but I wanted to maintain 
consistency with
how we currently get the ip address and don't make any unnecessary string
operations.
But, as I said, if you feel like this should be stripped, I'll go ahead 
and change it.





More information about the pbs-devel mailing list