[pbs-devel] [PATCH proxmox-backup v3] fix #4343: updated `view_task_result` to bail on task failure

[Maximiliano Sandoval]

On 9/8/23 15:32, Gabriel Goller wrote:
> Now we make an additional request on `api2/json/.../tasks/{upid}/status` to
> get the `exitstatus` of the task. This allows us to `bail` and thus
> get a non-zero exit code in the cli.
>
> Signed-off-by: Gabriel Goller <g.goller at proxmox.com>
> ---
>
> changes v2:
>   - removed unrelated cleanup
>
> changes v1:
>   - check on each iteration if the task is finished, then bubble up the
>     original error of the task. This was inpractical though, so we print
>     the error and return a generic error.
>
>   pbs-client/src/task_log.rs | 8 ++++++++
>   1 file changed, 8 insertions(+)
>
> diff --git a/pbs-client/src/task_log.rs b/pbs-client/src/task_log.rs
> index 0bbb928d..709d0d08 100644
> --- a/pbs-client/src/task_log.rs
> +++ b/pbs-client/src/task_log.rs
> @@ -96,6 +96,14 @@ pub async fn display_task_log(
>               }
>           }
>   
> +        let status_path = format!("api2/json/nodes/localhost/tasks/{upid_encoded}/status");
> +        let status_result = client.get(&status_path, None).await?;
> +        if status_result["data"]["status"].as_str() == Some("stopped")
> +            && status_result["data"]["exitstatus"].as_str() != Some("OK")
> +        {
> +            bail!("task failed");
The info about the exit status is not propagated, maybe one could display it too?
> +        }
> +
>           Ok(())
>       };
>