[pbs-devel] [PATCH proxmox-backup v2] close #3777: Add source information to backup logs
Gabriel Goller
g.goller at proxmox.com
Fri Sep 8 16:01:14 CEST 2023
This will show the ip-address of the client creating
the backup in the logs. For example it will output:
"starting new backup on datastore 'test1' from ::ffff:192.168.1.192:
"host/test/2023-08-21T07:28:10Z"".
Signed-off-by: Gabriel Goller <g.goller at proxmox.com>
---
update v1:
- improved unwrapping of ip adress
src/api2/backup/mod.rs | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/src/api2/backup/mod.rs b/src/api2/backup/mod.rs
index 652d5baa..18fad745 100644
--- a/src/api2/backup/mod.rs
+++ b/src/api2/backup/mod.rs
@@ -214,9 +214,12 @@ fn upgrade_to_backup_protocol(
env.debug = debug;
env.last_backup = last_backup;
+ let origin = match rpcenv.get_client_ip().map(|addr| addr.ip()) {
+ Some(ip) => format!(" from {ip}"),
+ None => "".into(),
+ };
env.log(format!(
- "starting new {} on datastore '{}': {:?}",
- worker_type, store, path
+ "starting new {worker_type} on datastore '{store}'{origin}: {path:?}",
));
let service =
--
2.39.2
More information about the pbs-devel
mailing list