[pbs-devel] [PATCH proxmox-backup 1/3] fix #4315: jobs: modify GroupFilter so include/exclude is tracked

Philipp Hufnagl p.hufnagl at proxmox.com
Wed Oct 25 17:07:05 CEST 2023

On 10/25/23 15:33, Thomas Lamprecht wrote:
> Am 24/10/2023 um 16:32 schrieb Philipp Hufnagl:
>> On 10/24/23 12:43, Lukas Wagner wrote:
>>> Do you have any examples in mind that would be more difficult to
>>> represent?
>> I would like to include all vms from 10 to to 30, but not 17,18 and 20.
> How is that more difficult?
> IMO Lukas proposal seems reasonable, a deterministic remove matches from
> excludes fromm all matches from includes seems easier to understand,
> from top of my head.

You would have to do something like

include 10-30
exclude 17
exclude 18
exclude 20

instead of

include 10-30
exclude 17-20
include 19

While the first is easier to understand, the 2nd one allows (in my
opinion) to build a cleaner solution for complex filtering.

However both are in my opinion fine solutions. I you think having 2
lists is a better solution I can implement that as well.

More information about the pbs-devel mailing list