[pbs-devel] [PATCH proxmox-backup 1/3] fix #4315: jobs: modify GroupFilter so include/exclude is tracked

Lukas Wagner l.wagner at proxmox.com
Tue Oct 24 12:43:10 CEST 2023

On 10/24/23 11:54, Philipp Hufnagl wrote:
>> I would probably do it this way:
>> no group-filters defined -> everything is included
>> only including filter    -> only groups matching the filter(s) are
>>                              included
>> only excluding filter    -> all groups but the matching ones are
>>                              included
> I am not 100% sure how I feel about including all as a starting point
> for exclusion filter. While I understand the intuitive benefit, it
> also may make the process more error prone, since removing 1 include
> filter may change everything to include all. User might not think of that.
>  >> including and excluding  -> first compute included groups, then subtract
>>                              excluded ones
> I considered this. The reason why I decided for only one list is
> because it enables user to make more sophisticated rules more easily.
> Having 2 lists that get processed after each other can make it much
> harder to filter on a complex setup.

Do you have any examples in mind that would be more difficult to

If you keep it as it is right now, there should be a way to reorder
match rules in the UI, maybe similar to the boot-order drag'n'drop
thing in PVE.

>> Ideally, this behavior should be
>>    a.) obvious in the GUI
>>    b.) documented in the docs, with a few concrete examples
> I see what I can do about explaining this behaviour better in the GUI
> and how to extend the documentation.

- Lukas

More information about the pbs-devel mailing list