[pbs-devel] [PATCH proxmox-backup v2] fix #4971: client: Improve output on successful snapshot deletion
Philipp Hufnagl
p.hufnagl at proxmox.com
Mon Oct 16 12:56:11 CEST 2023
When a snapshot gets deleted (forgotten), the proxmox backup client
currently returns returns
"Result: {
"data": null
}"
This feedback may confuse users therefore this patch changes the output
to
"Successfully deleted snapshot <snapshot>"
Signed-off-by: Philipp Hufnagl <p.hufnagl at proxmox.com>
---
Changes since v1
* Remove output message
proxmox-backup-client/src/snapshot.rs | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/proxmox-backup-client/src/snapshot.rs b/proxmox-backup-client/src/snapshot.rs
index 4ca8015f..fcfe5840 100644
--- a/proxmox-backup-client/src/snapshot.rs
+++ b/proxmox-backup-client/src/snapshot.rs
@@ -188,13 +188,13 @@ async fn forget_snapshots(param: Value) -> Result<Value, Error> {
let path = format!("api2/json/admin/datastore/{}/snapshots", repo.store());
- let result = client
+ client
.delete(&path, Some(snapshot_args(&backup_ns, &snapshot)?))
.await?;
record_repository(&repo);
- Ok(result)
+ Ok(Value::Null)
}
#[api(
--
2.39.2
More information about the pbs-devel
mailing list