[pbs-devel] [PATCH proxmox-backup] fix: ui: spinner position

Thomas Lamprecht t.lamprecht at proxmox.com
Fri Oct 13 14:38:33 CEST 2023

Am 12/10/2023 um 14:34 schrieb Dominik Csapak:
> On 10/12/23 13:49, Gabriel Goller wrote:
>> On 10/12/23 11:28, Dominik Csapak wrote:
>>> *if* we want to change this, we either would have to adapt pve/pmg as well,
>>> or refactor the class into the widget-toolkit (idk if there are some differences
>>> across products, though it shouldn't be), because we also use that for the task
>>> and job status list (e.g. replication)
>> I looked at them briefly and they have a few things in common, but imo
>> it's not worth the hassle combining them. We wouldn't **need** this in
>> pve/pmg but I could still submit a patch... let me know.
> Depends on your definition of **need**. If we don't do this,
> it would look differently e.g. for the task list in pve/pmg vs pbs
> and we want to have the UI consistent across products
> (except if there is a good reason to diverge) so for me it is
> important to stay consistent here.
> @Thomas any opinion on this?

I find Gabriel has a point, it looks odd as is, and aligning it right
makes it better fit in with other states like "OK" or "Error: ..".

Having something like "Running" as text here would be nice, but  we
cannot just use a `.x-grid-row-loading:after { content: 'Running' }`
as that misses translations.

One option would be to avoid ExtJS CSS here and use font-awesome like
"fa fa-fw fa-circle-o-notch fa-spin", the only disadvantage from that
is that we lose the site-wide synced animation that the currently used
GIF provides, can be worked around but IIRC there's nothing native
available for doing so.

For now the adapted CSS would be an OK stop-gap, IIRC we only use such
grid loading classes for such scheduled-job grids. Adding it to PVE
(isn't there even anything besides replication using that?) would be
good too though. IMO no need for widget toolkit, I'd keep this contained
for now.

More information about the pbs-devel mailing list