[pbs-devel] [PATCH proxmox-backup 2/2] ui: add Remove button for DirectoryList

Lukas Wagner l.wagner at proxmox.com
Tue Oct 10 11:13:06 CEST 2023



On 10/10/23 11:05, Markus Frank wrote:
>>>       store: {
>>>       fields: ['path', 'device', 'filesystem', 'options', 'unitfile'],
>>>       proxy: {
>>
>> A high-level comment about the UI changes:
>> In most places in our UI, we have a dedicated 'Remove' button right next
>> to the 'Add/Create' and 'Edit' button:
>>
>> [Add] [Edit] [Remove]
>>
>> We don't need 'Edit' here, but why not just add the button right next
>> to the 'Create: Directory' button?
>> What's the rationale of  moving the remove button to a menu on the
>> right-hand side?
> Because I think it would be better if it looks the same in pve & pbs.
> I think the reason for the menu in pve is that it is more difficult to 
> accidentally remove a directory.

Ah yes, you are right, I didn't compare it to PVE. In that case it's
probably fine and you can keep it that way.

-- 
- Lukas





More information about the pbs-devel mailing list