[pbs-devel] [PATCH proxmox-backup v2] ui: fix #4260: add dynamic notes in backup group comment

Philipp Hufnagl p.hufnagl at proxmox.com
Mon Oct 2 13:55:09 CEST 2023



On 10/2/23 13:13, Lukas Wagner wrote:
> On Mon Oct 2, 2023 at 10:38 AM CEST, Philipp Hufnagl wrote:
>> -		if (v === undefined || v === null) {
>> -		    v = '';
>> +
>> +		let additional_classes = "";
> 
> Note: I know the codebase is in some parts inconsistent in that regard, but
> for new code please use camelCase for variables and functions [1].
> 
> [1] https://pve.proxmox.com/wiki/Javascript_Style_Guide
> 
> Apart from that, the changes look fine and work as advertised.
> 
> Tested-by: Lukas Wagner <l.wagner at proxmox.com>
> 

Thank you for spotting! I made a v3





More information about the pbs-devel mailing list