[pbs-devel] applied-series: [PATCH proxmox-backup v2 1/3] ui: add 'show connection information' button for datastores

Thomas Lamprecht t.lamprecht at proxmox.com
Wed Nov 29 17:14:45 CET 2023


Am 29/11/2023 um 16:49 schrieb Dominik Csapak:
> this has a similar functionality as the 'show fingerprint' button,
> but for repository strings that are needed e.g. for the cli
> 
> included with and without the current user for convenience
> 
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
> changes from v1:
> * add help button
> * refactor the copy field (and remove the utils copy function)
> * put the button only in the datastore summary
> * style the copy buttons like toolbar buttons
> * add datastore and hostname also as copyable fields
> * seperate the cli/api fields with a title and (small) padding
>  www/Makefile                    |   1 +
>  www/Utils.js                    |   1 -
>  www/datastore/Summary.js        |  19 ++++-
>  www/window/DatastoreRepoInfo.js | 126 ++++++++++++++++++++++++++++++++
>  4 files changed, 145 insertions(+), 2 deletions(-)
>  create mode 100644 www/window/DatastoreRepoInfo.js
> 
>

applied, thanks!

I squashed two small fixes into yours, namely the one for the icon color to
also work with light mode (adding the x-btn-icon-el-default-toolbar-small to
iconCls) and renaming the window title to "Connection Information" to fit the
adapted button text.




More information about the pbs-devel mailing list