[pbs-devel] [PATCH proxmox-backup v3 0/6] fix #3690: wipe disk

[Lukas Wagner]

On 11/28/23 14:23, Markus Frank wrote:
> Wipe a disk/partition like we do in PVE. (wipefs, dd, change_parttype to 0x83
> with sgdisk)
> 

Looks good to me now, my comments from the first review
have been addressed and everything seems to work as expected.
Tested wiping individual partitions as well as whole disks.
EFI disks are protected (maybe this should be done with BIOS Boot 
partitions as well?) from accidental wipes.

The task log could be improved (e.g. printing the actual commands that 
were executed, 'wipe disk /sdx' is printed twice), but this can happen 
in a followup IMO.

Tested-by: Lukas Wagner <l.wagner at proxmox.com>
Reviewed-by: Lukas Wagner <l.wagner at proxmox.com>

-- 
- Lukas