[pbs-devel] [PATCH proxmox-backup 3/3] ui: datastore content: add action to show upload statistics

Thomas Lamprecht t.lamprecht at proxmox.com
Mon Nov 27 13:06:00 CET 2023


On 27.11.23 11:15, Dominik Csapak wrote:
> On 11/27/23 11:07, Thomas Lamprecht wrote:
>> On 27.11.23 10:28, Thomas Lamprecht wrote:
>>> we'd not add a core UI element for a rather niche information
>>> that most won't look at often.
>>
>> re-thinking this, maybe we want to put those things into a context
>> menu and expose that menu with a fa-bars or fa-toggle-down icon,
>> in addition with allowing one to trigger it with a standard right
>> click context menu (I wanted to add that for datastore content UI
>> since quite a while already).
> 
> sure, doesn't sound too complicated. i'd put the remaining actions
> also there. would you then still prefer a "general info" panel
> over just showing the upload statistics? (i guess so, but want
> to make sure)

Yes, and I'd also like that this is split (patch-wise) a bit so that
we do not have to use all or nothing now.

I.e., add context menu for existing actions and wire it up to right
click, that on it's own is a nice feature and doesn't needs anything
else mixed in.

Then add the new info thingy and add it only there for now.

Then rework a few of the existing actions out and add a (possibly
slightly filtered) fa-bars trigger-able menu there). IMO while the
other ones are relatively clear, this one has the most potential
for different opinion and UX workflow design and I'd not like to
being forced to rush that if I want the other (above) features now
already.






More information about the pbs-devel mailing list