[pbs-devel] [PATCH proxmox-backup 3/3] ui: datastore content: add action to show upload statistics

[Thomas Lamprecht]

On 27.11.23 11:04, Dominik Csapak wrote:
>>> +		    getClass: (v, m, rec) => rec.data.ty === 'dir' ? 'fa fa-info-circle' : 'pmx-hidden',
>>
>> info-circle is not a good icon for some specific stats, i.e., not a
>> general info about the backup snapshot.. A stop-watch could be nice,
>> but there doesn't seem to be any, so possibly "fa-file-text-o" (a
>> sheet of stat lines, so to say), not ideal too but IMO better than
>> the info-circle.
>>
>> ps. maybe injecting some more general info like duration could be
>> nice (didn't check if we even have that available already here
>> though).
>>
>> That said maybe one could even make this an actual info dialog,
>> with the stats only be one part of that, then the info-circle
>> could be OK too and we'd not add a core UI element for a rather
>> niche information that most won't look at often.
> 
> here we basically have only the info we have in the grid already,
> but we could provide it in a nicer way maybe:
> 
> backup time, files (+sizes), last verification info (+link to task log), etc.

Yeah, that's what I basically meant first, show the whole info a
bit nicer, possibly even hide some columns of it by default then
(the list is quite cramped already)

> 
> or did you mean we add a new api endpoint that returns more info about the snapshot
> altogether? (which could also make sense)

I mean, then we'd not have to "shove" in the upload stats into the
generic list snapshots API call, as you wrote yourself, especially
if we never plan to show those inline it might make really more
sense to split that, even if we'd have the manifest already read
and thus in memory.

Without an in-depth analysis, I think I'd prefer that slightly
more, especially as the maintenance cost of that extra endpoint
should be rather negligible (if there's a good API endpoint path
to put it in, as that sometimes seems to be the harder part ^^)

And yes, we could then show all the possible data about a
snapshot, even if some of that is currently already included in
the content tree.