[pbs-devel] [PATCH proxmox v2 1/2] sys: Use safe wrapper for libc::isatty

Maximiliano Sandoval m.sandoval at proxmox.com
Mon Nov 27 11:09:33 CET 2023


Fabian Grünbichler <f.gruenbichler at proxmox.com> writes:

> do we still need these two? I assume everything calling this would then
> do something with stdin/stdout anyway, and could just as well call
> is_terminal() on them? might be a candidate for deprecation, since the
> original reason for their existence (pulling out the `unsafe` part into
> a helper) is gone..

I tried sending patches for all possible users of those two functions,
but I might have missed some. I would mark them as deprecated once the
patches are applied.

--
Maximiliano





More information about the pbs-devel mailing list