[pbs-devel] [PATCH v2 proxmox-backup 2/3] node: status: added bootmode

[Lukas Wagner]

On 11/27/23 09:26, Gabriel Goller wrote:
> On 11/24/23 15:20, Lukas Wagner wrote:
> 
>>
>>
>> On 11/24/23 13:02, Gabriel Goller wrote:
>>>   +fn boot_mode_to_info(bm: boot_mode::BootModeInformation) -> 
>>> BootModeInformation {
>>> +    match bm {
>>> +        boot_mode::BootModeInformation::Efi => 
>>> BootModeInformation::Efi,
>>> +        boot_mode::BootModeInformation::EfiSecureBoot => 
>>> BootModeInformation::EfiSecureBoot,
>>> +        boot_mode::BootModeInformation::Bios => 
>>> BootModeInformation::Bios,
>>> +    }
>>> +}
>>
>> Mini nit: Maybe a From<boot_mode::BootModeInformation> impl would be a 
>> bit more idiomatic?
> Thought about this as well, but sadly the orphan rule ruins the day :(
> I also don't want to import `proxmox_sys` in `pbs-api-types` or viceversa.
>>
Ah yes, orphan rules... of course, didn't think about them during the 
review :D

-- 
- Lukas