[pbs-devel] applied: [PATCH proxmox-backup v6 0/6] local sync-jobs

[Thomas Lamprecht]

Am 21/11/2023 um 15:31 schrieb Hannes Laimer:
> Add support for local sync. SyncJobs without a remote are considered local, and
> use a different logic for pulling. In the course of adding the extra pull logic,
> the pull code was rewritten to basically be source independent. Also cli
> completion and the UI was updated to allow Remotes in SyncJobs to be optional.

> Hannes Laimer (6):
>   accept a ref to a HttpClient
>   pull: refactor pulling from a datastore
>   pull: add support for pulling from local datastore
>   manager: add completion for opt. Remote in SyncJob
>   api: make Remote for SyncJob optional
>   ui: add support for optional Remote in SyncJob
> 
>  Cargo.toml                           |    2 +
>  examples/download-speed.rs           |    2 +-
>  pbs-api-types/src/jobs.rs            |    9 +-
>  pbs-client/src/backup_reader.rs      |    2 +-
>  pbs-datastore/src/read_chunk.rs      |    2 +-
>  proxmox-backup-client/src/catalog.rs |    4 +-
>  proxmox-backup-client/src/main.rs    |    2 +-
>  proxmox-backup-client/src/mount.rs   |    2 +-
>  proxmox-file-restore/src/main.rs     |    4 +-
>  src/api2/config/remote.rs            |   16 +-
>  src/api2/config/sync.rs              |   41 +-
>  src/api2/node/tasks.rs               |    3 +-
>  src/api2/pull.rs                     |   60 +-
>  src/bin/proxmox-backup-manager.rs    |   67 +-
>  src/bin/proxmox_backup_debug/diff.rs |    2 +-
>  src/server/email_notifications.rs    |   18 +-
>  src/server/pull.rs                   | 1073 ++++++++++++++++----------
>  www/Utils.js                         |    5 +
>  www/config/SyncView.js               |    1 +
>  www/form/RemoteTargetSelector.js     |   36 +-
>  www/window/SyncJobEdit.js            |   73 +-
>  21 files changed, 934 insertions(+), 490 deletions(-)
> 


applied series, thanks!

Can you please sent a follow-up for Gabriel comment:

Am 22/11/2023 um 11:14 schrieb Gabriel Goller:
> You are allowed to create a local sync to the same datastore when using
> `proxmox-backup-manager` in the cli. You will not be able to run that sync
> job (neither the ui, nor the cli), but it would still be nice if there was
> some client-side error prohibiting you from creating the job.

As I also think that this is not fully ideal and should be blocked to happen
for better UX.