[pbs-devel] [PATCH proxmox-backup v6 0/6] local sync-jobs

[Hannes Laimer]

Add support for local sync. SyncJobs without a remote are considered local, and
use a different logic for pulling. In the course of adding the extra pull logic,
the pull code was rewritten to basically be source independent. Also cli
completion and the UI was updated to allow Remotes in SyncJobs to be optional.

v6: thanks @Gabriel and @Thomas for the feedback
 * disallow sync to same datastore
 * ui: fix not checked checkbox
 * ui: don't allow same datastore as source as the target
 * ui: render empty remote-id's the same way namespaces are
 * reorder patches, do config/api changes last
    (so instead of an Option pretending to be a String, we have a String
    pretending to be an Option, avoiding problems in intermediate patches)

v5: thanks @Thomas for the feedback 
 * ui: add radio buttons to make local vs remote more clear
 * move ui patch to the end + api2 -> api

v4: thanks @Wolfgang and @Lukas for the feedback
 * ui: disable rate limit for local sync jobs
 * ui: rename `Source Remote` -> `Source PBS`
 * update SYNC_JOB_WORKER_ID_REGEX, use '-' as remote for local
 * fix problme with groups not being synced to the correct ns
 * add check for source == target
 * moved two changes from patch 3 to patch 1

v3: thanks @Fabian and @Wolfang for the feedback
 * remove enums for Local/Remote
 * use traits, pull logic now expects a `dyn PullSource`(or `dyn PullReader`)
 * add lock to dir for local sync
 * split refactoring of pull logic and implementation of
    local pulling into two commits

v2: thanks @Fabian for the feedback
 * make pull logic more source independent

Hannes Laimer (6):
  accept a ref to a HttpClient
  pull: refactor pulling from a datastore
  pull: add support for pulling from local datastore
  manager: add completion for opt. Remote in SyncJob
  api: make Remote for SyncJob optional
  ui: add support for optional Remote in SyncJob

 Cargo.toml                           |    2 +
 examples/download-speed.rs           |    2 +-
 pbs-api-types/src/jobs.rs            |    9 +-
 pbs-client/src/backup_reader.rs      |    2 +-
 pbs-datastore/src/read_chunk.rs      |    2 +-
 proxmox-backup-client/src/catalog.rs |    4 +-
 proxmox-backup-client/src/main.rs    |    2 +-
 proxmox-backup-client/src/mount.rs   |    2 +-
 proxmox-file-restore/src/main.rs     |    4 +-
 src/api2/config/remote.rs            |   16 +-
 src/api2/config/sync.rs              |   41 +-
 src/api2/node/tasks.rs               |    3 +-
 src/api2/pull.rs                     |   60 +-
 src/bin/proxmox-backup-manager.rs    |   67 +-
 src/bin/proxmox_backup_debug/diff.rs |    2 +-
 src/server/email_notifications.rs    |   18 +-
 src/server/pull.rs                   | 1073 ++++++++++++++++----------
 www/Utils.js                         |    5 +
 www/config/SyncView.js               |    1 +
 www/form/RemoteTargetSelector.js     |   36 +-
 www/window/SyncJobEdit.js            |   73 +-
 21 files changed, 934 insertions(+), 490 deletions(-)

-- 
2.39.2