[pbs-devel] [PATCH proxmox 1/2] sys: Use safe wrapper for libc::isatty

[Maximiliano Sandoval]

Setting the MSRV is always a good idea. Will post a v2.

Fabian Grünbichler <f.gruenbichler at proxmox.com> writes:

>> Thomas Lamprecht <t.lamprecht at proxmox.com> hat am 19.11.2023 16:09 CET geschrieben:
>>
>> Am 17/11/2023 um 13:37 schrieb Maximiliano Sandoval R:
>> > Use the `std::io::IsTerminal` trait introduced in Rust 1.70.
>>
>> ack, but a more general question: should we set the msrv in the manifest:
>>
>> rust-version = "1.70"
>>
>> We did not bothered to much with that until now, only a bit indirectly through
>> increasing the edition to e.g., 2021, and we do not have that many external
>> users for it to matter much.
>
> I think that would make sense. most recent debcargo versions (not yet for us) translate this to the corresponding versioned dep, and the error messages are also much nicer and earlier in case somebody tries to build with a too old version..


--
Maximiliano