[pbs-devel] [PATCH proxmox-backup v5 6/6] ui: add support for optional Remote in SyncJob

Gabriel Goller g.goller at proxmox.com
Thu Nov 9 10:34:42 CET 2023


Hi!
I tested it a bit and it looks good so far, a few small ui issues though:
* When listing the sync-jobs, a local sync job has an empty 'Remote ID', 
which
     doesn't look that good. We could add a defaultValue that shows 
'Local' or
     something?
* We don't support syncs from and to the same datastore, so it also 
shouldn't be
     allowed to select it in the ui. Currently all the datastores are 
shown on the
     dropdown. These syncs also run successfully but don't sync 
anything, we should
     probably throw an error in the api if such a sync is requested. So 
that ui and
     api disallow same-datastore syncs.

On 10/6/23 16:05, Hannes Laimer wrote:
> Signed-off-by: Hannes Laimer <h.laimer at proxmox.com>
> ---
>   www/form/RemoteTargetSelector.js | 29 ++++++++-----
>   www/window/SyncJobEdit.js        | 72 +++++++++++++++++++++++++++++++-
>   2 files changed, 90 insertions(+), 11 deletions(-)
> [..]





More information about the pbs-devel mailing list