[pbs-devel] applied-series: [PATCH v5 proxmox-widget-toolkit 0/5] add LDAP realm support UI

[Thomas Lamprecht]

On 17/03/2023 09:47, Lukas Wagner wrote:
> This patch series adds support for adding LDAP realms, including user sync.
> 
> The GUI is mostly based on the implementation from PVE, with some slight
> adaptations - for details, please refer to the commit messages.
> The GUI components were added to the widget-toolkit repo, at some point PVE
> could be adapted to use the same implemention as PBS.
> 
> Changes v4 --> v5:
>   * No content changes, just rebased to current master as the patches
>     did not apply cleanly anymore
> 
> Changes v3 --> v4:
>   * use the `let me = this` pattern in the sync ui - strictly it is not needed,
>     but it may prevent errors if the code is ever modified.
>   * Fix bug reported by Friedrich [1], where a particular combination of
>     attributes could trigger a `value not defined in enumeration` error
> 
> Changes v2 --> v3:
>   * no changes in the UI patches
> Changes v1 --> v2:
>   * no changes in the UI patches
> 
> [1] https://lists.proxmox.com/pipermail/pbs-devel/2023-February/005938.html
> 
> Versions:
> 
> v1: https://lists.proxmox.com/pipermail/pbs-devel/2023-January/005788.html
> v2: https://lists.proxmox.com/pipermail/pbs-devel/2023-January/005844.html
> v3: https://lists.proxmox.com/pipermail/pbs-devel/2023-February/005914.html
> v4: https://lists.proxmox.com/pipermail/pbs-devel/2023-February/005953.html
> 
> 
> Lukas Wagner (5):
>   auth ui: add LDAP realm edit panel
>   auth ui: add LDAP sync UI
>   auth ui: add `onlineHelp` for AuthEditLDAP
>   auth ui: add `firstname` and `lastname` sync-attribute fields
>   auth ui: fix `value not defined in enumeration` error
> 
>  src/Makefile               |   2 +
>  src/Schema.js              |  12 ++
>  src/panel/AuthView.js      |  24 +++
>  src/window/AuthEditLDAP.js | 376 +++++++++++++++++++++++++++++++++++++
>  src/window/SyncWindow.js   | 192 +++++++++++++++++++
>  5 files changed, 606 insertions(+)
>  create mode 100644 src/window/AuthEditLDAP.js
>  create mode 100644 src/window/SyncWindow.js
> 


applied series, albeit I did not went for a full new in-depth review as this
is currently not used and bases a lot on the quite well working code of PVE,
so we can fix any nit/bug that turns up when we actually use it in PBS or
switch the implementation over in PVE, thanks!