[pbs-devel] [PATCH proxmox-backup] realm sync: show warnings if attributes do not meet their constraints

Lukas Wagner l.wagner at proxmox.com
Tue Mar 14 09:35:55 CET 2023

On 2/13/23 15:31, Lukas Wagner wrote:
> Previously, if the value of a synced property did not validate properly
> (e.g only 1 character in length instead of the required 2), the whole
> sync job failed without any useful error message.
> In this commit, the values are validated manually by their
> respective StringSchema. If the validation fails, the value is
> ignored and a warning is displayed in the task log.
> In addition to that, some error messages have been improved.
> Also, user sync is now more fault-tolerant in general, showing
> warnings if something goes wrong while creating/updating a
> single user, instead of aborting the whole sync job.
> Reported-by: Friedrich Weber <f.weber at proxmox.com>
> Signed-off-by: Lukas Wagner <l.wagner at proxmox.com>

Ping. Would be nice to get this in for the next release, as it improves the behavior
for the already merged user sync code.

There are two more smallish follow-up patches [1, 2] on the list which I won't ping
separately, since they are only cleanup.

[1] https://lists.proxmox.com/pipermail/pbs-devel/2023-February/005940.html
[2] https://lists.proxmox.com/pipermail/pbs-devel/2023-February/005939.html

- Lukas

More information about the pbs-devel mailing list