[pbs-devel] [PATCH proxmox-backup] jobstate: fix wrong error message

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Mar 7 19:36:57 CET 2023


Am 07/03/2023 um 15:10 schrieb Dominik Csapak:
> we try to create the job stat dir, not the rrdb one
> 
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
>  src/server/jobstate.rs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/server/jobstate.rs b/src/server/jobstate.rs
> index 4f347ad1..74af992f 100644
> --- a/src/server/jobstate.rs
> +++ b/src/server/jobstate.rs
> @@ -88,7 +88,7 @@ pub fn create_jobstate_dir() -> Result<(), Error> {
>          .group(backup_user.gid);
>  
>      create_path(JOB_STATE_BASEDIR, Some(opts.clone()), Some(opts))
> -        .map_err(|err: Error| format_err!("unable to create rrdb stat dir - {}", err))?;
> +        .map_err(|err: Error| format_err!("unable to create job stat dir - {}", err))?;

no biggie, but in general feel free (or even encouraged) to inline format string
variables when touching lines anyway, like {err} here.

>  
>      Ok(())
>  }






More information about the pbs-devel mailing list