[pbs-devel] [PATCH proxmox-backup 3/4] access: ldap check connection on creation and change

[Stefan Sterz]

On 26.06.23 14:59, Wolfgang Bumiller wrote:
> On Mon, Jun 26, 2023 at 02:40:38PM +0200, Stefan Sterz wrote:
>> On 26.06.23 14:36, Lukas Wagner wrote:
>>>
>>>
>>> On 6/26/23 11:39, Stefan Sterz wrote:
>>>>   macro_rules! DOMAIN_PART_REGEX {
>>>>       () => {
>>>> -        r#"("[^"]+"|[^ ,+"/<>;=#][^,+"/<>;=]*[^ ,+"/<>;=]|[^
>>>> ,+"/<>;=#])"#
>>>> +        r#"[^\s,\+=]+=(?:"[^"]+"|(?:\\[,\+=]|[^,\+=])+)"#
>>>>       };
>>>>   }
>>>>   
>>>
>>> I wonder, if we validate any change of the LDAP parameters against the
>>> actual server anyway, is there
>>> even any value in validating DNs using a regex?
>>>
>>
>> it could be dropped, i just assumed that having it there would help in
>> cases of obviously wrong dns and would save us the somewhat expensive
>> round-trip in such cases.
> 
> I guess we can just drop it.

alright, i'll send a v2 with that dropped in a minute.