[pbs-devel] [PATCH proxmox-backup 3/4] access: ldap check connection on creation and change

Lukas Wagner l.wagner at proxmox.com
Mon Jun 26 14:36:08 CEST 2023



On 6/26/23 11:39, Stefan Sterz wrote:
>   macro_rules! DOMAIN_PART_REGEX {
>       () => {
> -        r#"("[^"]+"|[^ ,+"/<>;=#][^,+"/<>;=]*[^ ,+"/<>;=]|[^ ,+"/<>;=#])"#
> +        r#"[^\s,\+=]+=(?:"[^"]+"|(?:\\[,\+=]|[^,\+=])+)"#
>       };
>   }
>   

I wonder, if we validate any change of the LDAP parameters against the actual server anyway, is there
even any value in validating DNs using a regex?

If the config is manipulated via the API, a malformed DN will be rejected by the server, and in case
the configuration file is edited directly, the regex also does not really help that much.

-- 
- Lukas





More information about the pbs-devel mailing list