[pbs-devel] [PATCH proxmox 2/4] ldap: add check_connection function

[Stefan Sterz]

On 26.06.23 14:23, Lukas Wagner wrote:
> Hello,
> 
> On 6/26/23 11:39, Stefan Sterz wrote:
>> +    /// Helper to check if a connection with the current
>> configuration is possible.
>> +    ///
>> +    /// This performs a search with the current configuration. If the
>> search succeeds `Ok(()) is
>> +    /// returned, otherwise an `Error` is returned.
>> +    pub async fn check_connection(&self) -> Result<(), Error> {
> 
> The `proxmox-ldap` crate actually has some integration tests, running
> tests against a
> real LDAP server (glauth). For reference, take a look at
> `tests/glauth.rs` and
> `tests/run_integration_tests.sh`. They are ignored by default, since
> they require the
> `glauth` binary in your `PATH`.
> 
> It would be cool if you could add some tests for this new function. Can
> of course happen in a
> followup patch! :)
> 
> 
Ah thanks, yeah i'll look into it, but i wanted to get this out in time
for the next release. the tests probably won't make it in time, hope
that's alright.