[pbs-devel] [PATCH v2 backup 0/5] Clippy fixes

Maximiliano Sandoval m.sandoval at proxmox.com
Fri Jun 16 10:27:26 CEST 2023


Differences from v1:

- Rebased on top of master
- Changed prefix to backup
- Added space in commits between description and signed by
- Changed commit descriptions to include the "Why is it bad" blurb instead of
  the URL, with the exception of the self-explanatory cast to i64

Maximiliano Sandoval (5):
  clippy fixes: the borrowed expression implements the required traits
  clippy fixes: use of ok_or followed by a function call
  clippy fixes: casting to the same type is unnecessary
  clippy fixes: Box::new(_) of default value
  clippy fixes: deref which would be done by auto-deref

 src/acme/plugin.rs             | 2 +-
 src/api2/admin/datastore.rs    | 2 +-
 src/api2/config/acme.rs        | 4 ++--
 src/api2/node/services.rs      | 4 +++-
 src/api2/tape/drive.rs         | 2 +-
 src/api2/tape/restore.rs       | 2 +-
 src/auth.rs                    | 6 +++---
 src/config/mod.rs              | 4 ++--
 src/config/tfa.rs              | 2 +-
 src/server/jobstate.rs         | 2 +-
 src/tape/drive/virtual_tape.rs | 8 ++++----
 src/tape/encryption_keys.rs    | 2 +-
 src/tape/media_catalog.rs      | 2 +-
 src/tape/media_pool.rs         | 4 +---
 src/tools/disks/mod.rs         | 2 +-
 src/tools/disks/zfs.rs         | 2 +-
 16 files changed, 25 insertions(+), 25 deletions(-)

-- 
2.39.2






More information about the pbs-devel mailing list